[cmake] Use a Find module for xxhash #5172
Merged
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crueter
force-pushed
the
xxhash-find
branch
2 times, most recently
from
94fda7c to
c1d8ef5
Compare
Port of FEX-Emu#5159 Find modules are preferred for pkgconfig/otherwise non-CMake libraries. Let's use that here for xxHash. Signed-off-by: crueter <[email protected]>
Sonicadvance1
approved these changes
Dec 29, 2025
neobrain
reviewed
Jan 5, 2026
| set(CMAKE_LINKER_FLAGS_RELEASE "${CMAKE_LINKER_FLAGS_RELEASE} -fomit-frame-pointer") | ||
|
|
||
| ## Modules ## | ||
| list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/CMakeModules/) |
Member
There was a problem hiding this comment.
Could you move this folder to Data/CMake/Modules? Trying to avoid too many randomly placed top-level directories, and it's more sensible to keep this closer to our other CMake utilities.
Collaborator
Author
There was a problem hiding this comment.
A top-level CMakeModules directory is usually preferred for Find modules and toolchains, but I can move this and LinkerGC in a PR if needed
Member
There was a problem hiding this comment.
Yeah, that convention probably makes sense for simpler projects, but our top-level got way too cluttered previously (to the point of hindering discoverability) with all the other things we juggle around. So a follow-up would be much appreciated!
crueter
added a commit
to crueter/FEX
that referenced
this pull request
Jan 5, 2026
See FEX-Emu#5172 (review). Signed-off-by: crueter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #5159
Find modules are preferred for pkgconfig/otherwise non-CMake libraries.
Let's use that here for xxHash.
Signed-off-by: crueter [email protected]